instride-ch/pimcore-data-definitions

AbstractSqlProvider: count on boolean value problem

Opened this issue · 0 comments

Q A
Bug report yes
Feature request no
BC Break report no
RFC no
Branch master

Found a potential problem in the import definition in AbstractSqlProvider.php on line 42:
if (count($data) > 0) { .... }

Here on line 38:
$data = $query->fetchAssociative();

the result can be false (bool) and count on bool is not allowed.

The problem occurred in PHP8.0 in Pimcore 10.5.15.