instride-ch/pimcore-data-definitions

Writeable parameter not set due to missing SettingsListener

Opened this issue · 3 comments

Q A
Bug report? yes
Feature request? no
BC Break report? no
RFC? no
Branch? master

Description:

There appears to be an issue, specifically related to the handling of pimcore.settings['data-definitions-import-definition-writeable']. This parameter is crucial for adding new definitions in the admin UI, but it seems not to be set properly. The probable cause is the absence of an implementation of a SettingsListener which is essential for initializing and setting such parameters.

Steps to Reproduce

  • Install and configure the w-vision DataDefinitions module on a Pimcore instance.
  • Navigate to the import or export definition panel, attempting to add a new definition.
  • Observe the failure or inability to add new definitions.

Expected Behavior

The admin UI should allow the addition of new data definitions seamlessly, with the data-definitions-import-definition-writeable parameter being set correctly.

Actual Behavior

The data-definitions-import-definition-writeable parameter is not set, preventing the addition of new definitions in the admin UI.

Possible Solution

For reference on how other bundles integrate the SettingsListener, see this example in the Pimcore repository: Pimcore CustomReportsBundle SettingsListener Implementation. Implementing a similar SettingsListener in the DataDefinitions module could resolve this issue.

@davidhoeck How did you solve this problem?

@twin-elements added a custom settings listener in our app which sets the parameters to true. of course just a workaround, because there needs to be a check of the storage is writeable or not.

@davidhoeck Thank you for your quick response :)