Module can cause endless loop
amenk opened this issue · 3 comments
amenk commented
The module can easily cause an endless lopp.
We use
return $this->session->getQuote()->getAllItems();
in our custom shipping calculator.
So
private function prepareShippingAddress(Quote $quote): Quote
{
$address = $quote->getShippingAddress();
causes a recursion on our case
We are evaluationg this further...
schmengler commented
Thank you, please keep us posted!
amenk commented
In the end of the day our custom shipping calculator might not be that cleanly implemented - it should use the items from the raterequest ...
amenk commented
We were able to fix this on our side (without a change in this module)