Topics from the old upstream repositories
Closed this issue · 13 comments
Unfortunately the original author of this package has not responded when we tried to make contact. As a result his repository could not be transferred and we had to fork instead.
Below are the topics that were open when we forked. Because we cannot close or merge these issues and pull-requests in the original repository, we instead mark them as resolved here, once that is actually the case.
Issues
- #24 Conflicts with org-hide-emphasis-markers
- #23 Suggested addition to README: use-packag
- #22 Font Awesome Pro 5.0.
- #17 wierd issue in emacs 25.1
- #15 Transform all bullets instead of just the last one for org-indent-mode
- #14 Bullets for TODO
- #12 Incorrect third bullet poin
- #11 Very slow performanc
Pull requests
Let me start with a few quick ones before working on some proper later:
sabof#13: wontfix. Reason: Already present in org-superstar.
sabof#23: wontfix. use-package, while popular, is not part of vanilla Emacs, and serves primarily as a convenience for end-users to simplify their init files. Those who use it would already know how to integrate a simple package into their config, those who don't won't find this info helpful.
sabof#12: seems to be correctly attributed (font issue). Since no further information has been provided, I would consider this issue resolved.
Oh right, I forgot.
sabof#14: wontfix. Reason: Present in org-superstar (see above).
Oh, hope it's okay I checked some of the checkboxes, @tarsius . These things are so alluring it's hard to resist 😅
That was the plan. 😉
The README as has been updated to address #11, see also integral-dw/org-superstar-mode#3.
sabof#19 and sabof#21 require some compromise. Yes, ideally this package should honor org-hide-leading-stars. However, if it did, I would either
- change the default behavior of org-bullets (forcing all current users to set the variable themselves), or
- mess with another packages variable.
I have a fix for this in Org Superstar, but I don't want to touch Bullets to the extent necessary.
However, honoring org-hide (the face) is zero cost, and probably what the user expects is done.
As for the rest of the proposed changes in sabof#21: There does not seem to be anything else that is salvageable. The mouse event code is long gone. What remains is a vestigial key map with no discernible use. The documentation seems to have changed too much as well, so not much to merge there.
I am not sure I understand sabof#15.
And then, when I copy and paste the block to send to someone, I get a mixture of regular (
*) stars and UTF-8 stars in the headlines.
The package does not change the buffer's contents, so the pasted content should not have any UTF-8 characters in the first place. If it's about "seeing" the asterisks when you mark a region, this can be mitigated by setting up org-hide (there are other tricks to do this, but those are out of the question because they would change too much code). So I guess it's a wontfix.
I fail to reproduce sabof#24 with emacs -Q. Given the Issue is from 2018, whatever caused the bug is either fixed now or it depends on missing information.
I also fail to reproduce sabof#17 (Emacs 26.3). This class of issues may relate to the font strangeness of Emacs 25.3 uncovered here. It is likely dependant on the OS's font config. Sadly there is not much I can do about it without more information. :(
Sadly there is not much I can do about it without more information.
IMO it is perfectly okay to consider such issues resolved here but you should probably comment on the original issue and state that the original poster has to provide more information if they are still experiencing the issue.
I was considering that, will do!
Done. I think that should take care of all issues for now. I have linked most issues to the repo itself instead of here, because I think it's best for them to open new issues should anything act up.
That makes sense and because I've listed all the issue urls above there's already a backlink anyway.