integrations/terraform-provider-github

[BUG]: `github_user` logins is not returning all valid users

julialawrence opened this issue · 3 comments

Expected Behavior

data "github_users" "all_users" {
  provider  = github
  usernames = local.user_list
}

should return the entire local.user_list between logins and unknown_logins

Actual Behavior

It appears to identify invalid users properly, but logins return way short of the input list minus unknown_logins

Terraform Version

Terraform v1.7.4
on darwin_amd64
+ provider registry.terraform.io/integrations/github v6.3.0

Affected Resource(s)

  • github_users

Terraform Configuration Files

data "github_users" "all_users" {
  usernames = local.user_list
}

Steps to Reproduce

No response

Debug Output

No response

Panic Output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct

@julialawrence I'm not an expert on the resources or data sources in the provider being queried from the GraphQL endpoint but it looks like pagination hasn't been enabled for the query so I guess that might be the issue here?

@stevehipwell that is my guess as well, however, as per https://registry.terraform.io/providers/integrations/github/latest/docs/data-sources/users which are the latest docs, there's neither an option to enable pagination nor a doc note to explain that the values returned might be incomplete due to it.

@julialawrence I think you'd need to work with the code rather than the docs in this case