Only show rewards on pools page if a user has claimable rewards

[tomjeatt]

This was raised by Jay. We've been having questions from users as to why the rewards on the pools page are showing as zero—now that rewards are no longer accruing, we should only show the rewards UI to users who have existing rewards to claim.

[danielsimao]

@peterslany we get the claimableRewards from getClaimableFarmingRewards at the amm modules.

[peterslany]

@peterslany we get the claimableRewards from getClaimableFarmingRewards at the amm modules.

@danielsimao Isn't this because the farming rewards already run out and 57% APR is based on trading fees that are automatically added to LP position and therefore does not need to be claimed?

[tomjeatt]

Yes, that's right—zero is the correct amount of rewards. The condition we need to check is whether there are existing unclaimed rewards.

…

On Mon, 20 Nov 2023 at 09:37, Peter Slaný ***@***.***> wrote: @peterslany <https://github.com/peterslany> we get the claimableRewards from getClaimableFarmingRewards at the amm modules. @danielsimao <https://github.com/danielsimao> Isn't this because the farming rewards already run out and 57% APR is based on trading fees that are automatically added to LP position and therefore does not need to be claimed? — Reply to this email directly, view it on GitHub <#1601 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AJTBEQUR34SEYPEW5RX7ZHLYFMQFDAVCNFSM6AAAAAA7N4DGXCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMJYGYZDMNBRHE> . You are receiving this because you authored the thread.Message ID: ***@***.***>

-- Distributed Crafts Ltd is a private limited company registered in England and Wales with company number 12286246. This email and any attachments may contain confidential and/or privileged information. If you have received this email in error, please notify us and delete the email immediately.

[tomjeatt]

Fixed and released