Remove simplejson dependency
cclauss opened this issue · 5 comments
Like internetarchive/openlibrary#2308 but for infogami. Also related to #80 @dherbst
- infogami/infobase/_dbstore/read.py
- infogami/infobase/_dbstore/save.py
- infogami/infobase/_dbstore/store.py
- infogami/infobase/logreader.py
- infogami/infobase/readquery.py
- infogami/infobase/writequery.py
- infogami/infobase/_json.py #168
- infogami/infobase/dbstore.py #168
- infogami/infobase/client.py #165 & #171
- infogami/infobase/common.py #174
- infogami/infobase/core.py #176
- infogami/infobase/infobase.py #176
- infogami/infobase/logger.py #176
- infogami/infobase/tests/test_client.py #137
- infogami/infobase/tests/test_save.py #137
- infogami/plugins/api/code.py #153
- infogami/utils/app.py #149
- infogami/utils/flash.py #149
- test/test_infobase.py #137
- tests/test_infogami/test_pages.py #137
grep simplejson **/*.py
can I take up this issue if its still a problem?
Sure @Enigma04, Thanks! Please approach across many pull requests in the following way...
- PR # 1 only modifies the tests (four files) and ensures that tests are running and passing before and after.
- PR # 2 utils (two files)
- PR # 3 api/code (just one file)
- Repeat the cycle with just one or two files in each PR (no big bang PRs with lots of files please)
- Do readquery and writequery files in the second last PR
- Do the _dbstore files in the last PR
Hopefully, @dherbst can help me review these PRs.
I have a doubt though, what should I replace in the programs that still uses simpleJSON in their code? Like I can remove the dependencies but it causes errors as we are using simplejson in the code. I am new to open source so if you could clear that for me it'll be great! Should I import json instead?
Yes. Please use the Python standard library’s json module as the replacement for simplejson.
I have made the pull request for the test files. Can you check?