The scripts/20YY (year) directories should be removed
Closed this issue · 5 comments
These scripts were written in legacy Python and will not be upgraded to run on Python so they should be zipped or moved to an archive repo or removed so that this repo contains valid Python code.
We can move them to an archive.org item or a separate repo e.g. openlibrary-archive.
In general, moving away from python2 is going to be rather challenging (given it will require a port of webpy and infogami
Webpy is now looking better. It passes the key flake8 tests and passes runtests.sh on all currently supported CPythons except 3.7.
So let's get crackin' on infogami... https://github.com/internetarchive/infogami/pulls
Would rather we just exclude scripts from our check
Re-opening this as a low priority thing for us to work on later. Here's a processed grep of all such scripts in olsystem. Not a guarantee of what's being used on prod, but not a bad measuring stick. It might have both false positive or negatives :/ .
./bin/cron/oldump.sh:#python $SCRIPTS/2012/dump-ia-items.py --host db-current --user archive --password $ARCHIVE_DB_PASSWORD --database archive | gzip -c > $iadump.txt.gz &
./bin/cron/oldump.sh:#python $SCRIPTS/2011/09/generate_deworks.py $dump/$dump.txt.gz $dump/$iadump.txt.gz | gzip -c > $dump/ol_dump_deworks_${date}.txt.gz
./etc/cron.d/openlibrary.allnodes:REPORT_ERRORS=/opt/openlibrary/openlibrary/scripts/2010/01/report_errors.py
./etc/cron.d/openlibrary.allnodes:59 23 * * * openlibrary /olsystem/bin/verify-node.sh ol-home && /olsystem/bin/olenv $SCRIPTS/openlibrary-server /olsystem/etc/openlibrary.yml runscript $SCRIPTS/2011/08/expire_accounts.py
Actually, this might be a blocker for python 3 migration; we need to know which of these scripts are actively being used...