intershop/intershop-pwa

Why you're using imports in TypeScript files which are pointing to node_modules of dev dependency directly?

Closed this issue · 2 comments

kepek commented

Is your feature request related to a problem? If yes, please describe it.

The problem isn't related to anything specific, it is more a question that has been already asked here in PR #1084

#1084

Describe the desired solution.

While playing with intershop-pwa as part of npm workspace I just discovered some troubles while building schematics. Mostly while typescript couldn't find some dependencies.

Describe alternatives you've considered.

I was wondering why you're not using direct imports from rxjs as it was previously.

Now:

import { switchMap } from '@angular-devkit/core/node_modules/rxjs/operators';

Before:

import { switchMap } from 'rxjs/operators';

Provide additional context.

It is in the context of npm workspaces and general monorepo idea.

AB#83987

kepek commented

I'm just thinking loud here, wouldn't be better to abstract intershop-schematics and publish it in npm as a completely separate dependency so it could be devDependency for intershop-pwa?

I'm just thinking loud here, wouldn't be better to abstract intershop-schematics and publish it in npm as a completely separate dependency so it could be devDependency for intershop-pwa?

Could be a good idea but it is currently not a priority. Maybe it becomes one if we would need our schematics for more than this one project.