iOS 13 Dark Mode?

Question

iOS 13 Dark Mode?

Opened this issue 5 years ago · 18 comments

Does this library support iOS 13's dark mode?

Answer 1 · 2019-10-08T14:30:09.000Z

We have added no additional logic, color schemes, etc. to deal with iOS 13's dark mode. If you would like to take up the research and/or implementation on that, it would be greatly appreciated. We can add a Hacktoberfest label as well.

Answer 2 · 2019-10-09T17:52:58.000Z

Hello @croossin. I will probably give it a shot :)

Answer 3 · 2019-10-09T18:14:35.000Z

Love it ;) Will assign the issue to you!

@lkeude96 Would also be cool to try and remove any sort of Turbo or Mint references so that the framework can be as generic as possible

Answer 4 · 2019-10-10T17:43:31.000Z

First Pass

👋 @croossin after looking at the codebase and the current available themes, I was thinking of potentially creating CardPartsSystemTheme and CardPartsCustomTheme (not sure if those would be the final names yet).

CardPartsSystemTheme would utilize the new Dynamic and Semantic System colors. Also this new theme would be used as the new default theme for CardParts.theme.
CardPartsCustomTheme would use the init(dynamicProvider:) initializer on UIColor with some of the original turbo color values. I'm not sure what would the adaptive color equivalents be but I could potentially come up a with a decent dark palette from them. CardPartsCustomTheme would mainly be used as an example to how to support dark mode.
In addition, I would update the README's Themes and add a subsection explaining how to support dark mode for card part.

Questions:

For the Turbo and Mint themes/references, Would be removing them entirely or just rename them?

Thank you, 😄

Answer 5 · 2019-10-10T17:48:25.000Z

I like the idea of the system and custom themes..!

I'm thinking that we can remove them and just add any of the values we are using inside the themes as a generic color extension. I just want to make the project as generic as possible.

Thanks for all the input!

Answer 6 · 2019-10-11T00:13:48.000Z

Work in progress.... (`CardPartsSystemTheme`) 😅

Answer 7 · 2019-10-11T03:15:29.000Z

Woo sweet!!

Answer 8 · 2019-10-11T12:28:18.000Z

@lkeude96 Thanks for looking into it. Looks great. Looking forward for the update soon!

Answer 9 · 2019-10-11T14:09:50.000Z

This is awesome, @lkeude96 ! Great job. Keep us updated

Answer 10 · 2019-10-22T14:58:06.000Z

@lkeude96 How's it coming along?

Answer 11 · 2019-10-23T08:12:29.000Z

@croossin 👋 Hi sorry for the delay. it's coming along great. Took slightly longer than expected due to some additional workaround in order to maintain backward compatibility. I will be opening a WIP pr soon to start getting feedback and in order to discuss how we want to expose those API to someone using the library. 😄

Answer 12 · 2019-10-23T14:49:55.000Z

Sounds good, @lkeude96 !

Answer 13 · 2019-10-23T15:32:53.000Z

Can't wait! :)

Answer 14 · 2019-10-30T14:23:17.000Z

@lkeude96 - how’s it coming along? Think we will be able to merge before end of month?

Answer 15 · 2019-10-30T23:32:49.000Z

@croossin Just open a WIP PR. 😅One of the main, thing i was still trying to get to work are shadows 🤔

Answer 16 · 2019-12-12T18:19:26.000Z

@lkeude96 Are shadows the only things missing from having dark mode support?

Answer 17 · 2020-03-30T02:44:43.000Z

How do we make the background of the CardPartsViewController dark like in the image @lkeude96 sent?

Answer 18 · 2020-04-08T04:46:49.000Z

Hey guys. Any update on this? Or anyway I could change the background colour of the VC?

First Pass

Work in progress.... (CardPartsSystemTheme) 😅

Work in progress.... (`CardPartsSystemTheme`) 😅