models: id_user -> user_id

[jirikuncar]

Shall we go with user_id or id_user everywhere?

See:

• user_id: https://github.com/search?utf8=%E2%9C%93&q=org%3Ainveniosoftware+user_id&type=Code&ref=searchresults
• id_user: https://github.com/search?utf8=%E2%9C%93&q=org%3Ainveniosoftware+id_user&type=Code&ref=searchresults

cc @inveniosoftware/triagers

[nharraud]

As this would imply changing other names too I did some other searchs:

• token:
  • token_id => 5 results
  • id_token => 0 results
• communities:
  • community_id => 15
  • id_community => 7
• session:
  • session_id => 2
  • id_session => 0
• page:
  • page_id => 1
  • id_page => 0
• profile:
  • profile_id => 1
  • id_profile => 0
• record:
  • record_id => 30
  • id_record => 2
• file:
  • file_id => 19
  • id_file => 0

This goes in the direction of what Google says (and everybody knows Google is always right ;) ):

• user_id => 22M
• id_user => 1M

Thus I would say, go with less refactoring, which means less bugs.

[kaplun]

For historical reference: in Invenio 1 id_foo was a foreign key to foo.id, whilefoo_id was instead a simple way to have an id that was not necessarily an auto-increment primary key.