invoiceninja/sdk-php

sendRequest adds ? in URL

Closed this issue 7 years ago · 3 comments

hjone72 commented 7 years ago

Hi,

When using archive, delete, and restore an error is thrown. "error": "Action [archive?] is not supported"

This is because of https://github.com/invoiceninja/sdk-php/blob/master/src/InvoiceNinja/Models/AbstractModel.php#L139 appends a ? separator when there is already an "?action=$action" in the URL.

Thanks,

hillelcoren commented 7 years ago

Thanks for catching this, are you able to create a pull request with your fix?

hjone72 commented 7 years ago

My bad. I thought I had created the pull request.

hillelcoren commented 7 years ago

Thanks for your help!