24-hours format (instead of AM PM 12-hours format) and date format settings are not respected in the task editor's timecode entry fields on Firefox (always inherits from browser language locale)
Opened this issue · 5 comments
Testing with the v5 Pro SaaS version today and in recent weeks, on Firefox 124 on Linux with the en_US locale (or "Scots", or...), it seems like the 24-hour setting still is not respected in the timecode fields, nor is the ISO 8601 date format (YYYY-MM-DD). Basically what I described in #1361 (comment) which was marked as solved, so I presumed it would have received a fix into the SaaS version (?) if it was fixed, but since I am still seeing the behavior I suppose it might have been forgotten amidst the issues described in that ticket, or that something else is going on.
Strangely enough, with the Epiphany (GNOME Web) browser, the times are shown in 24-hour format, and dates are shown in ISO 8601 format...
In both browsers, when I check my user settings page in InvoiceNinja, it is set to:
YYYY-MM-DD(ISO 8601) date format- 24-hours format
It is as if it was ignoring whatever you set in the preferences and just inherits from the browser's locale.
We preference the browsers default preferences for input values. Output values will be configured as per the settings configured in Invoice Ninja.
Browsers don't have an explicit AM/PM vs 24-hour format setting users can set though, and there are multilingual and multicultural countries (like Canada) where you cannot rely on the locale to decide things like preferred time formats, date formats, first-day-of-the-week, vs language. As far as I know there is no system locale that matches "someone in the US or Canada who wants to have everything in metric and ISO 8601 + 24-hour format while using any system language" (English, French, Spanish, Japanese...), for example...
@nekohayo that is exactly why we use the browser defaults.
The assumption being that the user would already be familiar with input styling that they commonly use anyway. We did make an attempt on this, however we quickly realised we could not cover all edge case over all locales.
Hmmm, is it possible that there is a misunderstanding here? Because I can assure you that, as far as I can tell, there is absolutely no way for a Canadian (or even an American?) to get ISO 8601 compliance for input with InvoiceNinja as you can see in this video here: https://youtu.be/ldYXJCMheE8 ... as shown, it is literally impossible for me to get both the date and time formats to be correct at the same time for inputs, no matter what I do with the browser, even though I explicitly told invoiceninja what formats I wanted in my user settings in the web interface. This is very strange.
I don't recall this being an issue for me with v4, somehow, and most other productivity apps respect my choice when I explicitly ask for standard YYYY-MM-DD 24:00 format.
I understand what you want to achieve, and we previously have attempted this in v5, however we were not able to cover all of the edge cases that become apparent when using custom datetime input fields. Hence why we have chosen to use default time and date inputs, which default to the browser/system defaults.