Set engineStrict flag in integration tests

Question

Set engineStrict flag in integration tests

Closed this issue 5 years ago · 7 comments

AlCalzone commented 5 years ago

to catch potential incompatibilities with the new fixer/installer versions

AlCalzone commented 5 years ago

I do.

Answer 1 · 2020-02-11T13:40:43.000Z

but only if nodejs >=10 because else all nodejs 8 test break!

Answer 2 · 2020-02-11T21:08:55.000Z

I thought we were going to downgrade semver?

Answer 3 · 2020-02-11T22:31:55.000Z

Yes but usually tests run against master ... and master will be pre-3.0 and so nodejs 8 killed ... or we disable nodejs 8 testing right with the release of the testing lib ... or make as major and tell devs to do it when updating

Answer 4 · 2020-02-12T11:27:18.000Z

I don't see the problem?! engineStrict is only incompatible with semver@>=7 right now. What does this have to to with Node.js 8 otherwise?

Answer 5 · 2020-02-12T11:36:52.000Z

Ok ... now i get it. you do not really install js-controller ... or ?!

Answer 6 · 2020-02-12T15:56:01.000Z

Oh, now I get it. The master branch is already at 3.0.0 and has the incompatible dependency.