Mark repo as unsupported?
lathonez opened this issue · 10 comments
Hey,
Lots of people from your community are putting their time into improving this example.
If the above comment is accurate, do you think it'd be worth stating on the readme that there's no point raising issues or PR (or perhaps disable that altogether if that's possible)?
If the above comment is not accurate - great stuff 😸
Let us know
Would be great to have a supported repository where the Ionic dev team and the community could work together to document best practices and methods for unit testing in Ionic. If this repo isn't it, then we need to find out how to get one together.
I for one think that the Ionic dev team should absolutely support an example project in order to display best practices for how to do testing (both unit and e2e) in Ionic. This was clearly the intention when starting this repo, and if it turns out not to be then the community should rally around one, similar to what has already happened in @lathonez's project.
@KyleMcNutt agreed. I was hoping to deprecate mine for an official version. I don't really mind if it's baked into the ionic-app-scripts or a standalone repo. Just somewhere we can get things working and have a discussion.
It's been all of 14 days since the last commit people 😂
Long term the goal is to have proper testing baked right in so this repo won't be necessary, in the meantime I'd like to have a maintainer on this with the goal of keeping it simple and not adding every possible feature. There's certainly room for alternative testing projects with a lot more bells and whistles that we could link to in addition to this.
If anyone is interested in that let me know 💪
Just added @leifwells as a maintainer
I'm here at ng-conf, so don't expect a lot of interaction from me before Saturday (April 8).
Contact me via gmail at leif.wells if you have thoughts.
Thanks for the update Max, great to have @leifwells on.
@lathonez If you have the time, could you do a review of any of the PRs we have in the queue? Make comments in code where you have questions/requests or comment on the main thread if you think it is ready for merge.
I'll be doing the same ASAP. Having others review will be helpful.
Anyone else can do the same. Review this code like people you respect will be using it. Set your standards high. Keep your comments civil. This project is by the community and for the community.
There's certainly room for alternative testing projects with a lot more bells and whistles that we could link to in addition to this.
I've decided to maintain clicker for the time being. I have a ~community over there who are bit stuck (as I am myself) since I looked into deprecation.
Also as the team are going to be baking this into ion-app-scripts at some point, it doesn't make a lot of sense for us to migrate existing code to this setup if there is an alternative - we'll just end up migrating again (to ion-app-scripts) down the line.
Am not interested in diluting the community on here - will reference and recommend this project on my blog and clicker readme.