iOS `buildNumber` is parsed as number

Question

iOS `buildNumber` is parsed as number

DavidStrausz opened this issue 2 years ago · 6 comments

The following commit introduced forced number parsing:
ba5f8f2

This is breaking and causes incorrect build numbers for projects that use build numbers that are in sync with the version (e.g. 1.0.0) instead of incrementing an integer (in this case 1.0.0 would be parsed as 1).

Answer 1 · 2023-02-11T15:32:27.000Z

Okay I'll need to go back to the drawing board with this one, thanks for the heads up

Answer 2 · 2023-02-12T17:06:50.000Z

@DavidStrausz what would you expect to happen here? Nothing, or semver increment?

Answer 3 · 2023-02-12T17:34:39.000Z

@mlynch Nothing I'd say, any logic regarding build numbers and other values should be handled by ci/cd scripts (e.g. faslane), and trapeze just applies the values set in config.yaml/env vars

Answer 4 · 2023-02-12T17:51:28.000Z

Ah nevermind, you aren't using this with increment. I got it

Answer 5 · 2023-02-13T14:46:06.000Z

Fixed in 7.0.8. Also fwiw Android versionCode only supports integers, so this fix was just for iOS

Answer 6 · 2023-02-13T15:13:42.000Z

I just updated and it's working as expected again! And yes you are right about the Android versionCode property.
Thank you, and great package btw! :)