Search for function definition redirects to signature file (`.fsi`) instead of implementation
64J0 opened this issue · 3 comments
Describe the bug
In VSCode, when I have both the signature and implementation files for the same functions and I want to go for the function implementation, it redirects me to the signature instead. It would be very nice if this behavior could be customized to redirect to the implementation instead (maybe some switch on the extension configurations).
Steps to reproduce
- Create both signature (
.fsi
) and implementation (.fs
) files for some function; - Call the function in another implementation file. Hover over the function name and hit Ctrl + Mouse left click (to redirect to the function implementation);
- Notice that you'll be redirected to the signature file instead of the implementation.
Link to sample reproduction
Expected behaviour
Redirect to the implementation instead of the signature.
If you're going to keep the redirect to the signature by default, it would be nice to have some configuration in the extension settings to allow it to redirect to the implementation instead of signature.
Screenshots
Machine info
- OS: Linux
- .NET SDK version: 7.0.401
- Ionide version: 7.16.1
Additional context
Add any other context about the problem here.
Yeah - we have several gaps in navigation/references/etc with regards to separating implementation, declaration, and definition. A lot of this should come down to locating and returning different locations for
- textdocument/declaration
- textdocument/definition
- textdocument/implementation
but we'd need to do that and see how far that gets us in covering the UX gaps.
I started some of that work in fsharp/FsAutoComplete#1111