iosphere/ISHPullUp

Bad type for bottomHiddenMargin property

Closed this issue · 1 comments

Lapinou42 commented

Hey,

I noticed something wrong in the code.

Line 208 in ISHPullUpViewcontroller.h =>
@Property (nonatomic) BOOL bottomHiddenMargin;

Based on the implementation code line 64 and 545 in ISHPullUpViewcontroller.m,
I think it should be =>
@Property (nonatomic) CGFloat bottomHiddenMargin;

Regards,

felixLam commented

Hi @Lapinou42 thank you for bringing this up. This was indeed an oversight on my part. We will get this fixed asap.