ipedrazas/drone-helm

"dry-run: true" still deployed a new helm chart

jpds opened this issue · 3 comments

jpds commented

I have a simple pipeline:

pipeline:
  helm_deploy:
    image: quay.io/ipedrazas/drone-helm
    skip_tls_verify: true
    chart: stable/prometheus
    update_dependencies: false
    release: prometheus
    namespace: production-prometheus
    dry-run: true
    secrets: [ api_server, kubernetes_token ]
    when:
      branch: [master]

Interestingly, when this ran, it actually deployed prometheus, into that namespace.

minhdanh commented

I think this is because the actual env var passed to drone-helm container by Drone is PLUGIN_DRY-RUN, not PLUGIN_DRY_RUN.

ipedrazas commented

Have you tried this?

pipeline:
  helm_deploy:
    image: quay.io/ipedrazas/drone-helm
    skip_tls_verify: true
    chart: stable/prometheus
    update_dependencies: false
    release: prometheus
    namespace: production-prometheus
    dry_run: true
    secrets: [ api_server, kubernetes_token ]
    when:
      branch: [master]