ipfans/echo-session

Invalid code in session.go

chrisprobst opened this issue · 4 comments

chrisprobst commented

Latest commit just broke the entire library:

https://github.com/ipfans/echo-session/blob/master/session.go#L67

Your current head IS NOT compatible with echo v3. There is no Writer() function. Please fix and revert. Your lib is broken now!

CHECK:
https://github.com/labstack/echo/blob/master/response.go#L14

ijust commented

Latest commit is pre-release.
https://github.com/labstack/echo/releases

In stable latest release, it is compatible.
https://github.com/labstack/echo/blob/v3.0.3/response.go#L14

Fix this problem, Please not revert and set git tags for vendoring properly.

ipfans commented

I think it is a good point that golang need a package management tool. 😄

If you use glide(or other package management tool like dep ), please use v3.0.0-rc1 instead of master branch.

  • 👍1
carynova commented

to fix it just delete the '()'
s := &session{name, rq, store, nil, false, rs.Writer}

meekmichael commented

Could a v3.0.0-rc2 be made with this PR plus the current master with the Postgres session code in it?