ipfs/aegir

type: 'module' or format: 'esm' should generate esm modules

whizzzkid opened this issue · 1 comments

whizzzkid commented

Right now the resulting dist/index.min.js does not provide named exports because the format is not set to esm. This happens because of padded umd banner and footer. The output should be esm which can then be imported for both the browser and node.

This can be achieved right now by setting package.json like so:

  ...
  "type": "module",
  ...
  "aegir": {
    "build": {
      "config": {
        "format": "esm",
        "banner": {
          "js": ""
        },
        "footer": {
          "js": ""
        }
      }
    }
  },
  ...

This should be selected by default if:

  1. package.json type is set to module
  2. build.config.format is esm
achingbrain commented

Typically node modules don't import the minified files, instead the ESM source or ESM transpiled from TS in dist.

Browser modules are typically bundled too so also import the ESM source/transpiled TS.

ESM should work as a minification option though.

Would you like to submit a PR that ensures there's no UMD wrapper when build.config.format is esm?

  • 👍1