Feature: update danger-js to fail PRs when adding two entries

Question

Feature: update danger-js to fail PRs when adding two entries

SgtPooki opened this issue 2 years ago · 3 comments

When a contributor creates a PR that adds multiple entries, we typically block on merging the PR and require each entry to be added separately. is this a process we want to keep?

If so, we should update the danger.js file to check that only a single entry is added.

Answer 1 · 2022-09-29T21:50:58.000Z

What's the reason for requiring each entry to be added separately?

Answer 2 · 2023-01-13T06:29:45.000Z

What's the reason for requiring each entry to be added separately?

That was the existing pattern. I believe it was intended to keep changes isolated and tie an owner to each added entry. I don’t feel strongly either way but prefer single/isolated additions.

Answer 3 · 2023-09-26T11:04:21.000Z

I think we can keep it light for now. If it becomes too difficult to review and maintain PRs, we can revisit this.