migrate to new cbor lib

Question

migrate to new cbor lib

whyrusleeping opened this issue 7 years ago · 7 comments

whyrusleeping commented 7 years ago

We should use https://github.com/polydawn/refmt, it was designed with a lot of our usecases in mind

Stebalien commented 7 years ago

Done.

Answer 1 · 2017-10-06T09:58:27.000Z

This lib could be also used for serialization of dagNodes (currently ipld modules are hard-coded with MarshalJson)

cc @Stebalien

Answer 2 · 2017-10-06T12:40:15.000Z

Missing pieces:

CBOR Tags: polydawn/refmt#7
~~UTF-8 Strings: polydawn/refmt#8~~ (we can write a validating adapter).
Big Numbers?

Answer 3 · 2018-07-17T17:47:31.000Z

Note: some quick benchmarking shows that the current library is slightly faster (especially when decoding). However, that may change when decoding/encoding directly to a datastructure rather than an object.

Answer 4 · 2018-09-11T01:19:37.000Z

Checking on status here. This is still WIP?

Answer 5 · 2018-09-11T01:26:42.000Z

Yes but it's getting close. I need to review and merge some CID changes (so we'll always just use cid.Cid instead of *cid.Cid). Then, we'll need to update the refmt version here and we should be good to go.

Answer 6 · 2018-09-11T01:28:15.000Z

That is great news :) Cheers Friedel

…

On 10. Sep 2018, 18:26 -0700, Steven Allen ***@***.***>, wrote: Yes but it's getting close. I need to review and merge some CID changes (so we'll always just use cid.Cid instead of *cid.Cid). Then, we'll need to update the refmt version here and we should be good to go. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.