ipfs/ipfs-webui

Download button should download from node, not gateway.

kevincox opened this issue · 2 comments

kevincox commented

Is your feature request related to a problem? Please describe.
When I download a file browsing my local node it often is slow or times out. This is because it is using the gateway rather than downloading from the node's API. This is annoying because I am on the same network as my node and it would be significantly faster, not even counting slowness in DHT traversal that the gateway needs to do.

The "Public Gateway" configuration on the settings page says

Choose which public gateway you want to use when generating shareable links.

A download isn't generating a sharable link so I don't understand why the public gateway should be used. I would expect it to download directly from the node's API.

Describe the solution you'd like
Downloads in the WebUI should use the API, not the public gateway.

Describe alternatives you've considered
Update the docs to state that the gateway is used both for downloads and generating sharable links. This would at least make the product consistent, but doesn't improve the performance issue.

Additional context
The version at the bottom of the WebUI is 2f9f306.

welcome commented

Thank you for submitting your first issue to this repository! A maintainer will be here shortly to triage and review.
In the meantime, please double-check that you have provided all the necessary information to make this process easy! Any information that can help save additional round trips is useful! We currently aim to give initial feedback within two business days. If this does not happen, feel free to leave a comment.
Please keep an eye on how this issue will be labeled, as labels give an overview of priorities, assignments and additional actions requested by the maintainers:

  • "Priority" labels will show how urgent this is for the team.
  • "Status" labels will show if this is ready to be worked on, blocked, or in progress.
  • "Need" labels will indicate if additional input or analysis is required.

Finally, remember to use https://discuss.ipfs.io if you just need general support.

SgtPooki commented

Thanks for reporting this @kevincox , I noticed this a while back and meant to file an issue for it but I don't think I did. It's a busy next few weeks but I'll try to get to this. It should be a pretty straightforward fix.

  • ❤️1