SIGINT doesn't interrupt the embeded node

Question

SIGINT doesn't interrupt the embeded node

Closed this issue 8 years ago · 3 comments

./ipget QmRrPRCRT3KEkQVBoA2f6X2jpbBEV7vgypbYJpVaoag4ia                               
^C^C^C^C^C^C^C^C^C^C^C^C^C

Answer 1 · 2016-09-14T17:59:04.000Z

Good catch, @Kubuxu. We need a way to provide https://github.com/noffle/fallback-ipfs-shell/ with a context so we can nix it from the outside. I'll add this to 1.0.0.

Answer 2 · 2016-09-14T18:07:12.000Z

You know, we could probably just os.Exit(1) without doing damage, since it's either hanging on a connection to a local daemon OR an ephemeral node it spun up. It'd be ideal to close cleanly, but for 1.0.0 this'd probably be fine.

Answer 3 · 2016-09-15T18:07:12.000Z

Filed #39 for making improvements to this.