ipfs/kuboreleaser

Kubo v0.22.0 feedback

Closed this issue · 11 comments

galargh commented

Improvements related to ipfs/kubo#9911

Jorropo commented

I don't like that GPG ask for me a passphrase:

Please provide a GPG passphrase for the key E73D5CF05FC2A3CD0A62C557C5B8248338D8A171.
GPG passphrase:

I guess it's gonna save it somewhere which kinda defeats the point of a passphrase.
After reading the source it loads the key, the text could be mentioned to explain how this key is used.

It does save it to .env.

Or better when I use git -S a GTK prompt automagically open to ask me for my passphrase when required, would be nice to do the same thing, also this has a "sudo mode" if I enter the password once with a session it does not reask me again in the short while.

Jorropo commented

Would be nice if the chore: update version commit was signed, (idk how it's gonna make the tag, if the tag is signed by me then this is not important).

Jorropo commented 
Your release PR is ready at https://github.com/ipfs/kubo/pull/10034\nIf needed, check out the release-v0.22.0 branch of ipfs/kubo repository and cherry-pick commits from master using the following command:

Is someone trying to use \n in an ` string literal ?

Jorropo commented

I would like to have a publish-to-all step that merge all the publish steps (ideally concurrently but fine if not).

BigLep commented

@Jorropo @hacdias : is there anything open here to still to handle or can we resolve?

hacdias commented

I don't think any of this has been handled yet

galargh commented

Here's a quick summary:

  • Prompt for GPG pass instead of saving it to .env - addressed in #23
  • Sign chore: update version commit - decided not to address it since the subsequent tag is signed by whomever drives the release
  • \n rendering - addressed in #23
  • add publish-to-all command (it should run all the other publish commands)
  • make sure marking releases as latest in ipfs/kubo works as expected (tldr, now, if we release a patch for the previous major/minor version, it will be marked as latest even though it should not)
  • add env command (it should do what make env does; it will allow installing kuboreleaser through go install without cloning the repo)
hacdias commented

(I guess I have to update my clone 😆 )

hacdias commented

I extracted the next steps to #30 , #31 and #32.