GetDetailsAsync should have overload that takes IPAddress
Closed this issue · 2 comments
Daniel15 commented
The IPAddress
class is the correct one to represent an IP address, and should be preferred over using a string
. https://docs.microsoft.com/en-us/dotnet/api/system.net.ipaddress
Can you please add an override for GetDetailsAsync
in IPApi
that takes an IPAddress
instead of a string
? You can call ip.ToString()
to get a string representation of the IP, and then pass that to the current string
-accepting method.
SobanMahmood commented
Thanks for your suggestion. That indeed will be useful to have such overridden method. We will get to it soon.
UmanShahzad commented
Solved in #12 - we'll release soon.