ipvm-wg/homestar

Add windows signal handling for ctrl-c, etc

zeeshanlakhani opened this issue · 3 comments

zeeshanlakhani commented

Summary

Currently, the homestar-runtime only supports unix signal handling for ctrl-c, sigterm, sigint. We should support Windows as well.

Solution

Implement https://docs.rs/tokio/latest/x86_64-apple-darwin/tokio/signal/windows/index.html as part of the shutdown signal handling.

euamcg commented

Hey I'd like to work on this issue.

  • ❤️1
zeeshanlakhani commented

You got it @euamcg! Thank you. Ping me on discord if you need help or anything.

zeeshanlakhani commented

done as part of #234