Collapsible Headings conflicts with Code prettify
lll9p opened this issue · 4 comments
When I clicked the code formatting button, the errors below comes out.
TypeError: cell is null
http://localhost:6666/nbextensions/collapsible_headings/main.js?v=20161018093041
Line 80
firefox49.0.1
jupyter-contrib-nbextensions (0.2.1)
notebook (4.2.3)
this results from code_prettify attempting to select an undefined cell, as a result of the commented out line at src/jupyter_contrib_nbextensions/nbextensions/code_prettify/code_prettify.js#L127
Indeed, there is another error in code_prettify; sorry for that.
There was some code remaining from a previous version where the index of the selected cell was passed to the yapf_format function. But actually the index is not defined anywhere anymore. That this actually works most of the time may be because since the index is undefined, then the select(index) does nothing and line 130 selects the correct cell.
I have just removed the reference to the index and corrected the code accordingly.
Tested on my configuration. Hope it will fix this.
thanks @jfbercher, I think your diagnosis seems correct, and usually it works because selecting an undefined cell isn't a problem. As a result, I think it makes sense to fix this on the collapsible_headings side as well, as @lll9p has done in #768