iris-hep/analysis-grand-challenge

Binning of signal and control region observable plots in cabinetry config file is incorrect

ekauffma opened this issue · 4 comments

As pointed out by @eguiraud, the bin labels should be 11 bins from 120 to 550. Only the labels are incorrect at this point, so it should be an easy fix

note to self: we'll also need to backport this if we go ahead with a v1.1

#165 will fix this for v1, we'll need to port over the same solution to main as well (after the refactoring in #158 is done).

The documentation is currently wrong too: https://agc.readthedocs.io/en/latest/taskbackground.html#observables-to-calculate should say "11 bins from 110 to 550" (and we should add "GeV").

#166 tracks the fix for main