irmen/Pyrolite

Strong-name sign the C# assembly?

stephentoub opened this issue · 6 comments

stephentoub commented

Would it be possible for you to strong-name sign the managed assembly? That's necessary for other strong-named assemblies to be able to reference it.

irmen commented

... I must confess that I don't really know what this is or how I go about doing it. Can you give me some relevant pointers on how I can proceed?

stephentoub commented

I put up a PR for it if you decide you want to go ahead with it: #63.

All I did was:

  1. Open the .csproj in Visual Studio.
  2. Right-click on the project in Solution Explorer and select Properties.
  3. Click on the Signing tab, click "Sign the Assembly", select "<New...>" from the drop-down, enter the name of a new file, uncheck "Protect with password", and click ok.

You can read more about the benefits at https://docs.microsoft.com/en-us/dotnet/framework/app-domains/strong-named-assemblies.

irmen commented

I'll have to figure out how to do this with the tools I'm using on my system (Linux with Rider and dotnet core).

irmen commented

@stephentoub I suppose the same holds for the dependent library Razorvine.Serpent ?

stephentoub commented

I suppose the same holds for the dependent library Razorvine.Serpent ?

Yup. I assume that's this?
https://github.com/irmen/Serpent/tree/master/dotnet/Serpent/Razorvine.Serpent
If you'd like to go ahead with this, I can submit a PR there as well if it would help.

irmen commented

That's the one. I think I got it, have a look at commit irmen/Serpent@763a6e1 over there.