iskandr/fancyimpute

Is pinning all versions really needed?

chyzzqo2 opened this issue · 2 comments

#138 added very specific version pins for all dependencies. This makes this package more difficult to use along side other packages that may have slightly different requirements. Would you consider relaxing some of this pins or converting to the more flexible > < notations?

Figuring out the specific pins was pretty difficult as a number of packages that fancyimpute relies on don't play nicely. If you can find a set of flexible versions that install and then run reasonably, I'd be happy to review the PR.

OK I had some time and #144 is the solution. Hopefully that's loose enough. Numpy is now the only version that I have to pin exactly to avoid issues with Tensorflow.