isleofcode/corber

Corber Removing Too Much From Android Manifest.xml

MatthewPringle opened this issue · 2 comments

I have this in my config.xml

<edit-config file="app/src/main/AndroidManifest.xml" mode="merge" target="/manifest/application">
    <application android:icon="@mipmap/ic_launcher" android:roundIcon="@mipmap/ic_launcher_round"/>
    <application android:usesCleartextTraffic="true"/>
    <application android:allowBackup="false"/>
</edit-config>

Corber seems to be removing the whole block, I believe you should only be removing <application android:usesCleartextTraffic="true"/>

This seems to happen in clean up after using Corber start and using CTRL C to end the process.

Fixed as of 1.4.3. Thank you!