function "Rmatrix3D" contains a critical typo where "incidence angle" is incorrectly written as "back-azimuth"
Seismic-wave-Han opened this issue · 0 comments
Seismic-wave-Han commented
I am about to use your awesome codes...
However, I found a major typo that may affect the use of 3D rotation.
In the "Rmatrix3D(baz,ain)" function in tools.py (pytheas version 0.2.3)
....
return np.asarray([
[np.cos(baz),-np.sin(ain)*np.sin(baz),-np.sin(ain)*np.cos(baz)],
[np.sin(ain), np.cos(ain)*np.sin(baz), np.cos(ain)*np.cos(baz)],
[0, -np.cos(baz), np.sin(baz)]
])
The rotation conversion matrix is reasonable only when the [0, 0] component of the returned array should be changed to "np.cos(ain)" not "np.cos(baz)".
Thanks!