Typo on document of Kafka-monitor API section
chihkaiyu opened this issue · 2 comments
chihkaiyu commented
Hi all,
I'd found a typo on this page: demo.crawled_firehouse.
It should be demo.crawled_firehose and I think it's just a typo.
I was stuck for a while and kept diving into the code to see if I did something wrong lol
Maybe we should add a warning (or an exception) here if someone tries to dump the result from a non-exist Kafka topic.
Not just create a topic and keep dumping the result from it but this is not the issue we want to discuss here.
Here is the related PR: #184
madisonb commented
Good catch, I am impressed that typo lasted as long as it did. Fixing right now... Ah I see you already made a PR -> I will resolve it here soon.
madisonb commented
PR Merged, closing.