italia/daf-dataportal

[Datasets info]: Lookup Superset tables by name and not by org_o_name

mariaclaudia opened this issue · 1 comments

Subject of the issue

Two superset tables with the same name are displayed in the same dataset page.
The name of the superset tables is the same but the path where they are stored is different.

The first one:
EDUC__luoghi.comune_torino_o_scuole_di_torino
https://bi.daf.teamdigitale.it//superset/explore/table/7719/

The second one:
SOCI__societa.comune_torino_o_scuole_di_torino su
https://bi.daf.teamdigitale.it//superset/explore/table/4279/

Steps to reproduce

Considering that it's not possible to use the same name for two different datasets also if they belong to different organisations and/or categories, in order to reproduce this issue you should create the first dataset then delete the catalog info but keep the superset table.
Then create a second dataset in a different place with the same name.

Expected behaviour

The lookup tables on superset should performed using the full path and not just by name (@raippl suggestion is that now the lookup is done by name instead of org_o_name)

Actual behaviour

Two tables are displayed from Superset.
The second one is still existing because probably in the past during some test, the datacatalog was deleted but not the superset table.

In general the issue is created not for this specific case that can be easily resolved deleting the old table but to underline the lookup by name and not by org_o_name.

screen shot 2018-07-17 at 17 30 04

Fixed by @raippl