Issues with XML and html/template
enrichman opened this issue · 1 comments
enrichman commented
SP Metadata are not correctly parsed since the html/template package is not meant for XML templating (see: golang/go#3133 )
It results in having the first line escaped in
<?xml version="1.0"?>
I would suggest to delegate the SAML XML logic to a more complete and robust library implementation, such as https://github.com/RobotsAndPencils/go-saml.
What do you think? 👍
alranel commented
Thank you for the report! Switched to text/template which does not provide XML escaping but it's fine for our needs.
The SAML package you linked actually looks abandoned, and generates invalid metadata: RobotsAndPencils/go-saml#9