Version restriction on asyncssh

Question

Version restriction on asyncssh

ghisvail opened this issue 3 years ago · 4 comments

ghisvail commented 3 years ago

What are the rationales for the version restrictions for asyncssh:

asyncssh>=2.7.1,<2.9

It currently makes dvc uninstallable on Nix due to asyncssh being newer.

I was wondering whether the upper bound could be dropped?

Answer 1 · 2022-03-16T09:08:18.000Z

It's to match https://github.com/fsspec/sshfs but in both cases the restrictions just weren't tested/updated when asyncssh released 2.9.

We should probably just change the upper restriction in both repos to the next major version instead of minor (so < 3 instead of <2.x)

Answer 2 · 2022-03-16T09:23:01.000Z

Ok, so there are API changes in 2.9 that break both this repo and sshfs (see the linked PR's), we'll have to update both repos before we can loosen the upper bound

Answer 3 · 2022-03-16T09:55:16.000Z

It's to match https://github.com/fsspec/sshfs but in both cases the restrictions just weren't tested/updated when asyncssh released 2.9.

I am not quite sure I follow. You are not depending on sshfs directly, are you?

Answer 4 · 2022-03-17T01:20:45.000Z

I am not quite sure I follow. You are not depending on sshfs directly, are you?

This package does not depend on sshfs, but DVC does, so supporting asyncssh 2.9 in scmrepo but not sshfs would not work as a solution to your issue