Branches
olls opened this issue · 5 comments
Following from this.
For repositories where we don't want the master branch to be pushed live, but another one. We need a way of specifying which branch to use. This could be done by specifying the branch name in the webhook URL, eg: http://git.dvbris.com/[branch-name]. (This would be easier once we've moved the secret out of the URL, #11)
Then github-listener can pass this branch name on to the github-getter (descendant of run.sh) which will get the correct branch.
Why? We can just use url.parse and have the branch as a query string.
But would be neater to have the branch in the path
On Fri, 14 Nov 2014 08:35 Geraint White notifications@github.com wrote:
Why? We can just use url.parse and have the branch as a query string.
—
Reply to this email directly or view it on GitHub
#13 (comment)
.
That can still be done with URL.parse
On Fri, 14 Nov 2014 08:44 Oliver Faircliff notifications@github.com wrote:
But would be neater to have the branch in the path
On Fri, 14 Nov 2014 08:35 Geraint White notifications@github.com wrote:
Why? We can just use url.parse and have the branch as a query string.
—
Reply to this email directly or view it on GitHub
<
https://github.com/itsapi/github-listener/issues/13#issuecomment-63024524>.
—
Reply to this email directly or view it on GitHub
#13 (comment)
.
Added support in github-listener fba21b4