itsleeds/UK2GTFS

Add Transfers.txt to ATOC

mem48 opened this issue · 7 comments

mem48 commented

Function is written needs to be intergrated and tested

Let me know if you want a hand testing/reviewing code.

mem48 commented

Thanks @Robinlovelace I'm adding tests at the moment and setting up travis.

If you want a tricky problem to think about: How do you check that the GTFS file produced is correct? Its easy to check the files are correctly formatted, but how you you check the actual timetable is correct?

I was thinking somethign that checked against google maps, but it is not a simple task to create.

I think the best way to test will be to compare routes generated by Google (possibly via the excellent googleway package) match the routes generated by opentripplanner that use the GTFS files that result from this package.

mem48 commented

But that would require building a national OTP graph, a big task, and then there are 400,000 train routes to check before you start on the busses.

googleway might be part of the solution, but ther needs to be a smart sampling system and I would prefer direct analysis of the GTFS files.

But that would require building a national OTP graph

Not if you test on a sample of the entire dataset, right?

mem48 commented

Not if you test on a sample of the entire dataset, right?

True but the regions have slightly different file structures, so it is possible to have region specific errors.

Develop a script that can generate a sample dataset and test for each region then would be my suggestion.