Correct And Simplify Memory Handling in xattr_get

Question

Correct And Simplify Memory Handling in xattr_get

Closed this issue 5 years ago · 4 comments

I notice your xattr_get routine is missing a check for an error from the PyList_Append call.

While I was at it, I took the opportunity to rework the xattr_get logic to reduce the complexity of the control paths, eliminating all the gotos. As you can see from the enclosed patch, it becomes much easier to verify that everything will be be correctly disposed regardless of what errors might occur.

ldo-xattr_get.patch.txt

Answer 1 · 2018-05-07T08:09:27.000Z

Sorry, noticed an omission in the patch. Update enclosed.

ldo-xattr_get.patch.txt

Answer 2 · 2019-11-17T14:48:33.000Z

Hi,

Refactoring the way error handling is dome is, I consider, more a matter of taste. I'd like to discuss that separately from fixing an actual bug. Can you rebase and split the patch into bug-fix and rework-error-handling?

Answer 3 · 2019-11-19T05:55:08.000Z

Code quality has nothing to do with “taste” (whatever that might mean).

Answer 4 · 2019-11-26T03:17:50.000Z

Error handling methods, as long as correct, are a matter of style, and not of "quality". I'll fix the PyList_Append error checking, if you do want to send a pull request for the refactoring, please do that separately.