Add icons and menu items

Question

Add icons and menu items

ivanstegic opened this issue 4 years ago · 13 comments

Requirements

Pull requests should be made on the develop branch of this repo. Start with release v0.0.1 and consider that when the app starts, the following should be true:

When clicking on the menu bar icon, the app should no longer exit
Clicking on the menu bar icon should reveal a menu that is only as high as the number of items in it and as wide as the widest item. There should be a reasonable amount of padding around the items, as per Apple design guidelines. See the Zoom menu screenshot for a good example.
The menu should have 3 items, the last two should be separated from those above it by a grey line, see the Zoom menu screenshot for an example for the grey line.
The item above the grey line should read Hello!
The 2 items below the grey line should read Help and Quit Menu Bar DNS
Clicking on Help should open the URL https://ivanstegic.com/menu-bar-dns/
Clicking on Quit Menu Bar DNS should quit the application (exit)
All app icons should be the same SVG as used for the menu bar icon
The menu bar icon should be white in color when the screen background is dark, and the current color when the background is light. Current behavior is shown below

icon-color-changes.mov

munirahmed007 commented 4 years ago

done.

Answer 1 · 2021-01-09T18:34:37.000Z

Hi @ivanstegic
to support the dark mode of screen, we must have a white version of the icon. Can you please provide me that? This way we don't need to handle it. Otherwise, I may have to handle the switch between white/dark programmatically which will need some effort.

Answer 2 · 2021-01-09T18:40:15.000Z

@munirahmed007 yes, of course! Here is the icon with a white fill. (I had to ZIP the file because the Github UI does not support SVG images for upload.)

barcode-box-fill-white.svg.zip

Answer 3 · 2021-01-09T22:09:42.000Z

cool. Thanks.

Answer 4 · 2021-01-10T03:14:45.000Z

PR is ready:
#6

Answer 5 · 2021-01-10T03:44:08.000Z

@munirahmed007 please can you do another PR from develop as in the issue?

Answer 6 · 2021-01-10T04:28:52.000Z

@ivanstegic
sure I changed the base in same PR. I hope that serves the purpose.

Answer 7 · 2021-01-10T05:20:44.000Z

@munirahmed007 i am afraid that the icon colors are not changing as i specified, see the video. You will notice that all the other icons change, except for Adobe's and Menu Bar DNS

dark-light-background.mov

Answer 8 · 2021-01-10T05:22:52.000Z

Also, the compiled .app file does not contain the App icons as specified

Answer 9 · 2021-01-10T19:59:12.000Z

HI @ivanstegic

the dark/light behaviour should be fixed.
for app Icon, I will require icns fie.

Answer 10 · 2021-01-10T20:00:29.000Z

either i could be .icns file with multiple size or, you can provide me image file for each size.
sizes requires are
16x16
32x32
64x64
128x128
256x256
512x512
1024x1024

Answer 11 · 2021-01-10T20:12:51.000Z

Here you go!

barcode-box-fill.zip

Answer 12 · 2021-01-10T22:49:42.000Z

Great! Accepting the PR, thank you.