Confusing naming between Schema and Validation.

Question

Confusing naming between Schema and Validation.

luishdez opened this issue 6 months ago · 6 comments

Shouldn't be the Objects inside shcema folder called GuestbookSchema and the Objects inside validations GuestbookEditValidation...or GuestbookEditSchemaValidation ( maybe too long) instead of using the name Schema inside validation?

meaning:
schema: Schema of the database
validation: Schema for validation

Answer 1 · 2023-12-14T16:51:44.000Z

Totally agree with you. It's really confusion.

Indeed, Schema should refer to the database.
And Validation should used for validation instead of Schema.

So, we can rename guestbookTable to guestbookSchema
And, then in validation folder, rename GuestbookSchema to GuestbookValidation, EditGuestbookSchema to EditGuestbookValidation and DeleteGuestbookSchema to DeleteGuestbookValidation.

Do you think you can create the PR?

Answer 2 · 2023-12-14T17:14:39.000Z

Awesome. Sure. I'll do the PR tonight.

Answer 3 · 2023-12-17T23:51:56.000Z

Hi @luishdez, do you need some help?

Answer 4 · 2023-12-20T00:25:00.000Z

Hi sorry for the delay. Unexpected catastrophe at work 🤦🏻‍♀️. I think I'll be ok with the refactor. Working on it.

Answer 5 · 2023-12-20T01:04:02.000Z

Thank you for your help. Sure, no problem at all.

Answer 6 · 2023-12-20T10:33:00.000Z

Thank you for all your help especially in a busy time for you!