Reset button on Web interface returns 404

Question

Reset button on Web interface returns 404

jsmestad opened this issue 7 years ago · 5 comments

The "Reset" button on the throttled interface returns a 404 Not Found though everything else on the Throttled page looks correct. Any ideas on what to check?

Answer 1 · 2017-06-12T21:00:29.000Z

Which version of sidekiq and sidekiq-throttled are you using?

Answer 2 · 2017-06-12T22:21:48.000Z

Sidekiq 4.2.10
sidekiq-throttled 0.7.2

Answer 3 · 2017-06-12T22:44:51.000Z

I was able to reproduce that. Thanks for the report. Will find solution ASAP

Answer 4 · 2017-06-13T16:36:38.000Z

@ixti awesome, would love to pitch in if you can give me any insight into what is happening

Answer 5 · 2017-06-13T17:28:26.000Z

So, we add delete action. According to specs, that delete action works perfectly correct. There's one trick about DELETE verb. There's no way to "issue" that verb using simple html attribute, so usually either XHR is used, or magic _method param is passed instead as part of POST form.

So, after sidekiq moved away from sinatra, I believe they have dropped support of that magic param. And most likely the solution is to simply replace method="post" with method="delete" for the form of the reset button. Although I'm not sure if that will be the right solution. So far I believe going the most dumb way will be better:

bind action to post instead of delete
change action's url to be throttled/{id}/reset