snapshot-timemachine file timestamp notes
Closed this issue · 3 comments
Hi,
It seems I failed to notice two things with the original code with #12.
Appologies.
the timestamp given for the record is the snapshot timestamp; is it possible to use the file timestamp instead?
Also; parse-time-string would be happier with a RFC 822 datetime:
"Parse the time in STRING into (SEC MIN HOUR DAY MON YEAR DOW DST TZ).
STRING should be something resembling an RFC 822 (or later) date-time, e.g.,
"Fri, 25 Mar 2016 16:24:56 +0100", but this function is
somewhat liberal in what format it accepts, and will attempt to
return a "likely" value even for somewhat malformed strings.
The values returned are identical to those of `decode-time', but
any unknown values other than DST are returned as nil, and an
unknown DST value is returned as -1."
Hey,
i'm busy this week - but i will take look at it on the weekend.
No worries; the change already simplified the code I needed dramatically!
What I ended up doing in the interim was real the file attributes directly:
https://github.com/mrBliss/snapshot-timemachine/pull/5/files#diff-e629dfd1557af6d626328a19d6eb6161R365-R366
@kryptt sorry for the delay.
I created a new repo for zsd.
The next release of zfs-snap-diff
will be without zsd
- so i can create releases independently.
I have implemented your suggestions in j-keck/zsd@134aa38e and released the new version: v1.1.2.
You can get it from the zsd site.
I'm closing this issue here - please re-open the issue in the zsd repo if something is missing.
Thanks