CORS error on https://api.memegen.link/templates/

Question

CORS error on https://api.memegen.link/templates/

Josehower opened this issue 3 years ago · 10 comments

Thank you for this API is amazing and we have been using it to teach React on our coding Bootcamp for some years now.

I found that some days ago trying to fetch the templates from https://api.memegen.link/templates/ is throwing a CORS error.

This is are the links to the app that used to work before

Deployed: https://react-meme-scraper.netlify.app/

Repo: https://github.com/Josehower/React-meme-generator

Please let me know if this is intended.

and thank you in advance for any help you can give me here.

Good energy 👍👍👍👍

Answer 1 · 2022-02-17T12:02:06.000Z

That is mostly likely caused by #678. I'll investigate...

Answer 2 · 2022-02-17T12:30:11.000Z

OK, this should be fixed by dfe7a9c. Thanks for the report and let me know if that's not working for you!

Answer 3 · 2022-02-17T15:29:37.000Z

Thanks for the fast response!

Answer 4 · 2022-02-17T15:34:44.000Z

@jacebrowning unfortunately the cors error is still happening.

I am going to try to send "no-cors" mode. But still, this may break a lot of projects using the last implementation.

EDITED: I can also confirm the no-cors mode doesn't work.

Answer 5 · 2022-02-17T15:53:51.000Z

@Josehower is it possible something is cached on your end? This is what I see on your site:

Answer 6 · 2022-02-17T16:39:53.000Z

@jacebrowning unfortunately the cors error is also happening for me

Answer 7 · 2022-02-17T16:40:05.000Z

I cleaned the cache tried from incognito mode and used a different Browser, all of these environments throw me the CORS error.

I asked a colleague and the issue is happening for him too.

Again, thank you for your attention and quick response.

Answer 8 · 2022-02-17T17:04:40.000Z

Can one of you paste the values or share a screenshot of the Headers tab for the templates request?

You should see access-control-allow-origin: * for an uncached request.

Answer 9 · 2022-02-17T19:58:44.000Z

KK Just checked from my mac and now I got the right response.

thanks for your help. 🙌

Answer 10 · 2022-02-17T21:12:13.000Z

Good to know! It's possible there's still a misconfiguration (see sanic-org/sanic-ext#62 (comment) regarding OPTIONS) but I think this may have just taken a while for the cache to propagate.