storing multivalue reference should not eliminate duplicates

Question

storing multivalue reference should not eliminate duplicates

Closed this issue 10 years ago · 4 comments

https://github.com/jackalope/jackalope-doctrine-dbal/blob/master/src/Jackalope/Transport/DoctrineDBAL/Client.php#L948 is doing an array_unique. i think we fixed bugs elsewhere that allowed to store the reference to the same target multiple times.

Answer 1 · 2014-12-05T16:54:35.000Z

this will also be a problem with jackalope/jackalope#242

Answer 2 · 2015-01-08T09:31:33.000Z

is this now fixed?

Answer 3 · 2015-01-08T09:41:54.000Z

there is still the call to array_unique so if there is no failing test it means we are missing a test that stores the same ref multiple times. (reading, when data is loaded through fixtures probably already works)

Answer 4 · 2015-01-08T09:43:08.000Z

the line moved to https://github.com/jackalope/jackalope-doctrine-dbal/blob/master/src/Jackalope/Transport/DoctrineDBAL/Client.php#L1001 since i created the issue. guess there is a point to link to a specific commit for these things...