Copy binary data for children nodes

[bitpetr]

Hi,
In \Jackalope\Transport\DoctrineDBAL\Client:copyNode() line 698 we execute query to copy binary data, but according to update params we are trying to copy the same data every iteration

WHERE b.node_id = ? [$srcNodeId]

since $srcNodeId is id of the root source node, not current iteration children node.

Is this by mistake or is this intended?

[lsmith77]

yeah this looks like a bug to me as well

[dbu]

it would be awesome if you can write a failing test in https://github.com/phpcr/phpcr-api-tests/blob/master/tests/Writing/CopyMethodsTest.php and then fix. that way we know there really was a problem and we also know its fixed and will stay fixed... do you have time to look into that @rederrik? we are of course here to help you getting set up if needed.

[bitpetr]

Sure, the fix seems to be easy enough.
So I need to make 2 pull requests - 1 for this repo and one for tests repo, right?

[dbu]

great! exactly, needs two separate pull requests. if you `composer update --prefer-source`, you can develop the test bit inside the vendor folder (if you already have the code as non-git checkout just remove vendor/phpcr/phpcr-api-tests first.

[bitpetr]

#297 and phpcr/phpcr-api-tests#167 to fix it.

[dbu]

very cool, thanks a lot for working on this!