jackalope/jackalope-doctrine-dbal

[query] why add selector in dcr:name?

Opened this issue · 2 comments

dbu commented

as discovered with jackalope/jackalope#301, we seem to have a duplication of the selector name. why do we under some circumstances add the selector name to dcr:name in
https://github.com/jackalope/jackalope-doctrine-dbal/blob/master/src/Jackalope/Transport/DoctrineDBAL/Client.php#L2329 ? having it in dcr:selectorName would be enough (and actually simpler) for jackalope.

I am pretty sure all of this was initially created with little understanding of things and just trying to emulate Jackrabbit as much as possible.

dbu commented

in this case, jackrabbit is not adding the selector in the column name, and only the order of the code in jackalope led to correct column names.