jackalope/jackalope-doctrine-dbal

Fatal error on PHP 8.0.0

Closed this issue · 1 comments

I know, the constraints don't claim PHP 8 compatibility (yet) but I thought I'd do a quick lint of all the files and this error popped up:

PHP Fatal error:  Declaration of Jackalope\Test\Fixture\XMLDocument::save($file = null) must be compatible with DOMDocument::save(string $filename, int $options = 0) in vendor/jackalope/jackalope-doctrine-dbal/tests/Jackalope/Test/Fixture/XMLDocument.php on line 123
Errors parsing vendor/jackalope/jackalope-doctrine-dbal/tests/Jackalope/Test/Fixture/XMLDocument.php
dbu commented

i had started work to run tests on php 8 in #373 - but i ran out of time.

i move your finding to that issue and close this one.